Attention is currently required from: fixeria, laforge, pespin.
falconia has posted comments on this change by falconia. (
https://gerrit.osmocom.org/c/libosmo-abis/+/39731?usp=email )
Change subject: trau: new function osmo_trau2rtp_ufe()
......................................................................
Patch Set 3:
(6 comments)
File src/trau/trau_rtp_conv.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/6a3ce467_8ca4cfa5… :
PS2, Line 249: * \param[in] emit_twts002 self-explanatory
Same, not self-explanatory.
Resolved in
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/70624bbd_9a2f4402/
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/76427d24_2399df94… :
PS2, Line 260: return -EINVAL;
ufe is left uninitialized here.
Resolved in
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/27668a3c_341e3e03/
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/79964b5b_52570e92… :
PS2, Line 263: return -ENOSPC;
ufe is left uninitialized here.
Resolved in
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/27668a3c_341e3e03/
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/8d205de4_d46e5e2b… :
PS2, Line 282: return 0;
ufe is left uninitialized here.
Resolved in
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/27668a3c_341e3e03/
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/e0b85775_06dd7f62… :
PS2, Line 299: return 1;
ufe is left uninitialized here.
Resolved in
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/27668a3c_341e3e03/
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/5bd84693_5f4a66bf… :
PS2, Line 311: return GSM_HR_BYTES_RTP_RFC5993;
ufe is left uninitialized here.
Resolved in
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/27668a3c_341e3e03/
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/39731?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I7a90eca296b17b1211e5c2125fb1496cd362e1c9
Gerrit-Change-Number: 39731
Gerrit-PatchSet: 3
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Mar 2025 20:24:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>