Attention is currently required from: fixeria, pespin, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/33753 )
Change subject: gmm: Update DRX params during rx RAU REQ ......................................................................
Patch Set 1:
(1 comment)
File src/sgsn/gprs_gmm.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/33753/comment/0be65c6a_3c7a2b0a PS1, Line 1770: TLVP_PRESENT
Don't we need to check the length before copying `sizeof(mmctx->drx_parms)` bytes?
TLVP_PRES_LEN could possibly be used. Or the code in libosmocore that defines minimumg length for each IE, as well as permitted/required IEs and which would then be called once before passing any messages further down into various handling functions which then can all rely on the guarantees provided by the shared/common validation.