21 Jan
2025
21 Jan
'25
5:44 p.m.
Attention is currently required from: dexter, laforge.
fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37454?usp=email )
Change subject: global_platform: LOAD and INSTALL [for load] support ......................................................................
Patch Set 8: Code-Review+1
(2 comments)
Patchset:
PS8: Looks good, except the missing `required` argument.
File pySim/global_platform/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/37454/comment/b7dcc821_8288bca1?usp=ema... : PS8, Line 824: add_mutually_exclusive_group You're missing to add `required=True` here. At least one argument must be supplied, right?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37454?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I924aaeecbb3a72bdb65eefbff6135e4e9570579e
Gerrit-Change-Number: 37454
Gerrit-PatchSet: 8
Gerrit-Owner: laforge laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: dexter pmaier@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Tue, 21 Jan 2025 16:44:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes