Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/33193 )
Change subject: Add osmo_io support to osmo_stream_cli and osmo_stream_srv
......................................................................
Patch Set 1:
(3 comments)
File include/osmocom/netif/stream.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7898):
https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/5a5590f3_cf5589a7
PS1, Line 83: void osmo_stream_cli_set_iofd_read_cb(struct osmo_stream_cli *cli, int
(*read_cb)(struct osmo_stream_cli *cli, struct msgb* msg));
"foo* bar" should be "foo *bar"
File src/stream.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7898):
https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/a3857a0b_3d9626cd
PS1, Line 931: int (*read_cb)(struct osmo_stream_cli *cli, struct msgb* msg))
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7898):
https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/53f8a81e_80dd734c
PS1, Line 1729: }
void function return statements are not generally useful
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/33193
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I2f52c7107c392b6f4b0bf2a84f8c873c084a200c
Gerrit-Change-Number: 33193
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Jun 2023 15:07:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment