Attention is currently required from: osmith, laforge, fixeria.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27923
)
Change subject: Check VTY config against features reported by BTS
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/33f56416_35dee4ad
PS6, Line 502: if (!bts_gprs_mode_is_compat(bts, bts->gprs.mode)) {
&& instead of nested if?
File src/osmo-bsc/bts_osmobts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/ab7009b7_0617aac9
PS6, Line 208: /* Adjust bts_init/bts_model_init in OsmoBTS to report new features.
i wonder what this comment attempts to say, sounds like legacy that we can drop?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/27923
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa
Gerrit-Change-Number: 27923
Gerrit-PatchSet: 7
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Apr 2022 13:34:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment