Attention is currently required from: dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37456?usp=email )
Change subject: pySim-smpp2sim.py: Simulate SMSC+CN+RAN+UE for OTA testing ......................................................................
Patch Set 3:
(5 comments)
File pySim-smpp2sim.py:
https://gerrit.osmocom.org/c/pysim/+/37456/comment/501d4171_5a319bc1 PS3, Line 34: from pprint no longer used?
https://gerrit.osmocom.org/c/pysim/+/37456/comment/b0223980_2b60ec94 PS3, Line 41: from zope.interface import implementer curious: what package this belongs to?
https://gerrit.osmocom.org/c/pysim/+/37456/comment/5b06594f_beadc2da PS3, Line 59: logger = logging.getLogger(__name__) so you have a module local logger module (which is good), but still mostly using the root logger (`logging.foo()` instead of `logger.foo()`) down below?
https://gerrit.osmocom.org/c/pysim/+/37456/comment/36e53396_371fc409 PS3, Line 95: submit unused?
https://gerrit.osmocom.org/c/pysim/+/37456/comment/f8ed11e9_6b1dd4e5 PS3, Line 101: data FYI: you can use `pformat()` from `pprint` as follows:
``` logging.info(pformat(data)) ```
in case you still want to achieve pretty printing like in previous patchset revision.