Attention is currently required from: dexter.

View Change

5 comments:

• File pySim-smpp2sim.py:

  • Patch Set #3, Line 34: from pprint

    no longer used?

  • Patch Set #3, Line 41: from zope.interface import implementer

    curious: what package this belongs to?

  • Patch Set #3, Line 59: logger = logging.getLogger(__name__)

    so you have a module local logger module (which is good), but still mostly using the root logger (`logging.foo()` instead of `logger.foo()`) down below?

  • Patch Set #3, Line 95: submit

    unused?

  • Patch Set #3, Line 101: data

    FYI: you can use `pformat()` from `pprint` as follows:

    ```
    logging.info(pformat(data))
    ```

    in case you still want to achieve pretty printing like in previous patchset revision.

To view, visit change 37456. To unsubscribe, or for help writing mail filters, visit settings.