Attention is currently required from: fixeria, jolly, lynxis lazus.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/35567?usp=email )
Change subject: VTY: Add command `show bts online`
......................................................................
Patch Set 1:
(2 comments)
File src/osmo-bsc/bsc_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/35567/comment/1be7eba2_c792ca27
PS1, Line 262: Display availability status of all BTS
`online` in the command name suggests that the command
is supposed to show only those BTS instances, […]
I think we already used
'summary' in some similar cases on the VTY interface. But 'brief' also
works for me. The 'online' also confused me. ACtually twice: First I read it as
"oneline" and was wondering how the status of 256 BTSs in one line looks like.
Then the "show only online BTSs" meaning that fixeria pointed out.
https://gerrit.osmocom.org/c/osmo-bsc/+/35567/comment/d624d09d_fb7c994e
PS1, Line 268: for (bts_nr = 0; bts_nr < net->num_bts; bts_nr++)
Not a performance critical path, but I would still
suggest doing this: […]
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/35567?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I003fd32e589ddf53b7dd42089f904cfb598e3625
Gerrit-Change-Number: 35567
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 18 Jan 2024 09:00:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment