Attention is currently required from: fixeria, jolly, lynxis lazus.

View Change

2 comments:

• File src/osmo-bsc/bsc_vty.c:

  • Patch Set #1, Line 262: Display availability status of all BTS

    `online` in the command name suggests that the command is supposed to show only those BTS instances, […]

    I think we already used 'summary' in some similar cases on the VTY interface. But 'brief' also works for me. The 'online' also confused me. ACtually twice: First I read it as "oneline" and was wondering how the status of 256 BTSs in one line looks like. Then the "show only online BTSs" meaning that fixeria pointed out.

  • Patch Set #1, Line 268: for (bts_nr = 0; bts_nr < net->num_bts; bts_nr++)

    Not a performance critical path, but I would still suggest doing this: […]

    Ack

To view, visit change 35567. To unsubscribe, or for help writing mail filters, visit settings.