Change in osmo-bsc[master]: Add BTS setup ramping to prevent BSC overloading

Attention is currently required from: neels, laforge, fixeria, pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Patch Set 16: (7 comments) File include/osmocom/bsc/bts_setup_ramp.h: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/5881e245_9af48487 PS3, Line 31: BTS_SETUP_RAMP_INIT, /** initial state */ One is just wrong. doxygen doesn't accept a single one. Or maybe you're using a different version or config of doxygen. It's either /*! (java doc) or /**< but not /*< according https://www.doxygen.nl/manual/docblocks.html#specialblock I've tested it with doxygen using the config from libosmocore. I've switched to /*!, but honestly we should have a linter yelling here as well. File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/275d9f81_3c967533 PS4, Line 3100: bts-setup-ramping-step-interval As pespin proposed I followed the example of access-control-class-ramping and be consistent with access-control-class-ramping. I don't want to do more review rounds with different taste and style between different reviewers. A proper solution for this would be a vty style guide including good and bad examples. File src/osmo-bsc/bts_setup_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/4f4a3b8e_c9a0262f PS4, Line 98: && net->bts_setup_ramp.step_size > 0 Done https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/a7d62928_386b6fd1 PS4, Line 101: net->bts_setup_ramp.active Done https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/225ab2d6_e9c3bcaa PS4, Line 201: INIT_LLIST_HEAD(&bts->bts_setup_ramp.list); Maybe I missed the point. But I don't see any issue with the current implementation nor do I understand why it needs to be an explicit comment in here. File src/osmo-bsc/bts_setup_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/7d943aaf_9af8c4e2 PS15, Line 51: if (llist_empty(&bts->bts_setup_ramp.list)) good point. only possible after patchset14 https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/4a93f6bd_846517e9 PS15, Line 74: net->bts_setup_ramp.count >= net->bts_setup_ramp.step_size) Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 16 Gerrit-Owner: lynxis lazus &lt;lynxis(a)fe80.eu&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-CC: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Fri, 11 Nov 2022 14:53:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels &lt;nhofmeyr(a)sysmocom.de&gt; Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt; Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt; Comment-In-Reply-To: lynxis lazus &lt;lynxis(a)fe80.eu&gt; Gerrit-MessageType: comment