Attention is currently required from: fixeria, laforge.
falconia has posted comments on this change by falconia. (
https://gerrit.osmocom.org/c/libosmo-abis/+/39731?usp=email )
Change subject: trau: new function osmo_trau2rtp_ufe()
......................................................................
Patch Set 2:
(3 comments)
File src/trau/trau_rtp_conv.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/8d0f6488_f62a05c9… :
PS1, Line 458: static int trau2rtp_efr(uint8_t *out, size_t out_len, const struct
osmo_trau_frame *tf, bool emit_twts001)
likewise
Done
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/b9346341_9f3f56c4… :
PS1, Line 247: * \param[in] tf input TRAU frame in decoded form
the new ufe output argument should be documented here
in the comment.
Done
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/3047209b_3211b07c… :
PS1, Line 346: * \param[in] emit_twts002 self-explanatory
likewise
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/39731?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I7a90eca296b17b1211e5c2125fb1496cd362e1c9
Gerrit-Change-Number: 39731
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Mar 2025 23:36:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>