Attention is currently required from: fixeria, laforge.
jolly has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531?usp=email )
Change subject: sctp_common: gen_sockopts/1: add heartbeat and RTO params
......................................................................
Patch Set 2:
(1 comment)
File config/sys.config:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531/comment/1c0b1dfe_798ca... :
PS2, Line 17: %% * rto_initial - RTO (retransmission time-out) initial, ms (default: 1000)
I'm not sure we want to provide defaults for RTO ourselves, I'd say let the kernel pick them up. […]
I suggest to use our values as defaults, rather than the kernel defaults. A timeout of about 10 minutes makes no sense for S1 link.
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I081852d2df187ca7c3cb8969686530b8ac3644f3
Gerrit-Change-Number: 41531
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-CC: jolly
andreas@eversberg.eu
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Mon, 01 Dec 2025 12:03:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de