14 Oct
2023
14 Oct
'23
3:49 p.m.
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34742?usp=email )
Change subject: osmo_epdg_app: Fix formatting error in log string ......................................................................
Patch Set 1:
(1 comment)
File src/osmo_epdg_app.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34742/comment/36864888_45394... PS1, Line 8: ~n Why is this an error? Looking at osmo_dia2gsup.git, I see all strings are `~n`-terminated. And BTW, why do we still use `lager` at all? Erlang now offers the built-in `logger` module: https://www.erlang.org/doc/man/logger.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34742?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Ib8dfa40ad028f959e4816ce5056ff64d52ec647b
Gerrit-Change-Number: 34742
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Sat, 14 Oct 2023 04:49:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment