Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34395?usp=email )
Change subject: OBS: don't downgrade version in debian/changelog ......................................................................
Patch Set 1:
(1 comment)
File scripts/obs/lib/debian.py:
https://gerrit.osmocom.org/c/osmo-ci/+/34395/comment/94bc88d0_629d636f PS1, Line 101: if packaging.version.parse(version_changelog.split("-")[0]) > \
isn0t this going to crash if you didn't successfuly import packaging. […]
This function only gets used after lib.check_required_programs() gets called, which ensures that the packaging python module is there.
The try...except logic is to make the startup work on our jenkins:
1. ./update_obs_project.py --docker … runs outside of docker 2. it imports scripts/obs/lib/debian.py and other scripts outside of docker, here it would fail without try...except 3. it runs the script inside a docker container 4. there the import works, does not go into the except code path 5. lib.check_required_programs() runs, ensures that the python library is there 6. changelog_add_entry_if_needed() runs