Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36148?usp=email )
Change subject: stp: add and use f_m3ua_{cli,srv}_config() helpers ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File stp/STP_Tests_M3UA.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36148/comment/97b5e5fb_99aa9... PS1, Line 110: mtc.stop;
You are clearly not seeing the benefit because you are still using 2 lines to do something which can be done in one: [...]
I never liked doing it this way. The benefit of writing one long line doing several things in one go is questionable, especially when you need to log some values and thus have to use `log2str()`. We are not limited by the number of code lines, so I prefer using `setverdict()` explicitly, rather than hiding it behind the scenes of overloaded functions like `f_shutdown()`.