21 Sep
2022
21 Sep
'22
8:30 p.m.
Attention is currently required from: Mark Boldyrev, laforge, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29439 )
Change subject: shell: Use a double asterisk for kwargs ......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS3:
Seems like unit tests are boken with this patch. Feel free to have a look: […]
You need to modify contrib/jenkins.sh. Currently it installs cmd2==1.5.
BTW, there is also: https://cgit.osmocom.org/pysim/log/?h=fixeria/cmd2 which works for me.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/29439
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: laforge/cmd2_2.4
Gerrit-Change-Id: I19d28276e73e7024f64ed693c3b5e37c1344c687
Gerrit-Change-Number: 29439
Gerrit-PatchSet: 5
Gerrit-Owner: Mark Boldyrev markboldyrev@gmail.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: Mark Boldyrev markboldyrev@gmail.com
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Wed, 21 Sep 2022 18:30:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mark Boldyrev markboldyrev@gmail.com
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment