Attention is currently required from: pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/33610
)
Change subject: ASCI: Add encoding of VGCS/VBS A-interface messages
......................................................................
Patch Set 3:
(1 comment)
File src/osmo-bsc/osmo_bsc_bssap.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/33610/comment/1595a44d_0454109a
PS2, Line 1752: struct gsm0808_vgcs_vbs_setup_ack sa = {
this looks a bit weird, for zero-initialized structs
we usually use formatting "= {};" or "= {0};"
Makes sense. (I
had some values in it earlier.)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/33610
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic2203a5119a226ac859a91dc42d81cbd71027ec8
Gerrit-Change-Number: 33610
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Jul 2023 11:41:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment