Jenkins Builder has posted comments on this change by falconia. (
https://gerrit.osmocom.org/c/osmo-bts/+/38553?usp=email )
Change subject: CSD: implement half-rate modes correctly
......................................................................
Patch Set 1:
(6 comments)
File src/common/l1sap.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19465):
https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/3e93bb42_b18a51dc?usp… :
PS1, Line 2064: const uint8_t *data, uint16_t data_len)
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19465):
https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/1510371f_47b52466?usp… :
PS1, Line 2064: const uint8_t *data, uint16_t data_len)
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19465):
https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/9de6dd21_398f2fe8?usp… :
PS1, Line 2092: const uint8_t *data, uint16_t data_len)
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19465):
https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/5de453ae_a4b829da?usp… :
PS1, Line 2092: const uint8_t *data, uint16_t data_len)
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19465):
https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/47c1f6de_38b2229d?usp… :
PS1, Line 2126: const uint8_t *data, uint16_t data_len)
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19465):
https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/60fe7884_d97e4f6a?usp… :
PS1, Line 2126: const uint8_t *data, uint16_t data_len)
please, no space before tabs
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/38553?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib35e910df263743cd243f51fb0bd6551ddfcf4c5
Gerrit-Change-Number: 38553
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Sun, 27 Oct 2024 17:48:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No