Attention is currently required from: fixeria, laforge, osmith, pespin.
Hello Jenkins Builder, fixeria, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-uecups/+/40788?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Code-Review+1 by osmith
Change subject: gtp_endpoint: Avoid deadlocks logging while thread is cancelled
......................................................................
gtp_endpoint: Avoid deadlocks logging while thread is cancelled
We cannot guarantee that LOGP will not end up calling a syscall which can
be a cancellation point. Since the syscall will be probably called while
having the logging mutex locked, an eventual cancellation of the thread
would leave the logging mutex locked forever, hence making all other
threads deadlock as soon as they try to write anything to the log.
Similar to what's already done in tun_device_thread().
Change-Id: I1e141175440402a7db34f3d246104c6ea38031fb
---
M daemon/gtp_endpoint.c
1 file changed, 25 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/88/40788/4
--
To view, visit
https://gerrit.osmocom.org/c/osmo-uecups/+/40788?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-uecups
Gerrit-Branch: master
Gerrit-Change-Id: I1e141175440402a7db34f3d246104c6ea38031fb
Gerrit-Change-Number: 40788
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>