Attention is currently required from: laforge, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28678 )
Change subject: trxcon: support handling of multiple L1CTL client connections ......................................................................
Patch Set 6:
(2 comments)
File src/host/trxcon/src/l1ctl_server.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28678/comment/14c0fe08_6c6b15d3 PS6, Line 55: "L1CTL server has lost connection (id=%u)\n",
looks like you want to print id inside LOGP_CLI directly, not here.
No, because at this point you don't have struct trxcon_inst associated with struct l1ctl_client. This is done in client->server->cfg->conn_accept_cb().
https://gerrit.osmocom.org/c/osmocom-bb/+/28678/comment/7674b2f7_2c994ede PS6, Line 167: LOGP(DL1C, LOGL_NOTICE, "L1CTL server got a new connection (id=%u)\n", client->id);
Use LOGP_CLI
Same here, struct trxcon_inst is allocated and associated in client->server->cfg->conn_accept_cb(). I intentionally print "got a new connection" before calling it because logging chronology looks more logical this way.