Change in osmocom-bb[master]: trxcon: support handling of multiple L1CTL client connections

Attention is currently required from: laforge, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28678 ) Change subject: trxcon: support handling of multiple L1CTL client connections ...................................................................... Patch Set 6: (2 comments) File src/host/trxcon/src/l1ctl_server.c: https://gerrit.osmocom.org/c/osmocom-bb/+/28678/comment/14c0fe08_6c6b15d3 PS6, Line 55: "L1CTL server has lost connection (id=%u)\n", No, because at this point you don't have struct trxcon_inst associated with struct l1ctl_client. This is done in client->server->cfg->conn_accept_cb(). https://gerrit.osmocom.org/c/osmocom-bb/+/28678/comment/7674b2f7_2c994ede PS6, Line 167: LOGP(DL1C, LOGL_NOTICE, "L1CTL server got a new connection (id=%u)\n", client->id); Same here, struct trxcon_inst is allocated and associated in client->server->cfg->conn_accept_cb(). I intentionally print "got a new connection" before calling it because logging chronology looks more logical this way. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28678 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id92e5b553487e4cf10ea291b487a3ef0c65d72ae Gerrit-Change-Number: 28678 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Jul 2022 12:06:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment