[S] Change in osmocom-bb[master]: trxcon: use non-blocking stderr logging by default

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32518 ) Change subject: trxcon: use non-blocking stderr logging by default ...................................................................... trxcon: use non-blocking stderr logging by default The logging in trxcon is initialized by calling osmo_init_logging2(), which creates an stderr target in *blocking* mode. Blocking write()s may cause random burst scheduling delays (due to the whole process being stuck). This is not desired and becomes even more critical when operating in PS doman, which imposes strict timing requirements. trxcon does not have its own VTY interface yet, so there's currently no easy way to switch to non-blocking mode like in other osmo-apps. Let's enable it by default in trxcon_logging_init(). Change-Id: I8cbfd9b4644f8442cbedc7e452ba79816923fc10 Related: OS#5500 --- M src/host/trxcon/src/logging.c 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/host/trxcon/src/logging.c b/src/host/trxcon/src/logging.c index b80f00d..e873045 100644 --- a/src/host/trxcon/src/logging.c +++ b/src/host/trxcon/src/logging.c @@ -92,6 +92,7 @@ int trxcon_logging_init(void *tall_ctx, const char *category_mask) { osmo_init_logging2(tall_ctx, &trxcon_log_info); + log_target_file_switch_to_wqueue(osmo_stderr_target); if (category_mask) log_parse_category_mask(osmo_stderr_target, category_mask); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8cbfd9b4644f8442cbedc7e452ba79816923fc10 Gerrit-Change-Number: 32518 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged