Attention is currently required from: pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/28895
)
Change subject: bts_trx_vty: do not print nmstate of bb_trxc mo
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/bts_trx_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28895/comment/df83cbc3_c11fdc13
PS1, Line 743: if (!is_ericsson_bts(trx->bts)) {
Since you are implementing BBTRANSC for OM2000 in next
patch, I don't see a reason to have this. […]
Yes, but this is just a display
issue and I think it would be nicer to not to display the BBTRANSC mo here. I will keep
this patch in the patch set for a while. We can decide later if we abandon it or not.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/28895
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I0f5501f6fbc7ce6d5457676b16c7f93f70db5763
Gerrit-Change-Number: 28895
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Aug 2022 08:39:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment