Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/39952?usp=email )
Change subject: SMS-over-GSUP: send network-originated MT-forwardSM-Err ......................................................................
Patch Set 1:
(1 comment)
File src/libmsc/gsm_04_11.c:
https://gerrit.osmocom.org/c/osmo-msc/+/39952/comment/2b592b5a_4457fbd5?usp=... : PS1, Line 1332: rate_ctr_inc(rate_ctr_group_get_ctr(net->msc_ctrs, MSC_CTR_SMS_DELIVERED));
Wrong place for what? This FIXME is about incrementing a counter way too early. […]
I'm not saying it's related to this patch, just flagged it in case you want to take the chance to fix it now that you have the code fresh, since it may be easy to fix.