Attention is currently required from: pespin, dexter.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/32934 )
Change subject: Add support for receiving Bter UI frames at lapdm.c
......................................................................
Patch Set 9:
(1 comment)
File src/gsm/lapdm.c:
https://gerrit.osmocom.org/c/libosmocore/+/32934/comment/9a3c2fa9_6f81212b
PS8, Line 740: sapi = (msg->l2h[0] >> 2) & 7;
This offset is wrong, because sapi begins after
two-byte L1 header. Also see below.
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32934
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If04115884743455c7bf2b2bc5f7e49e74b6ffb60
Gerrit-Change-Number: 32934
Gerrit-PatchSet: 9
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Jun 2023 08:28:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Gerrit-MessageType: comment