Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41752?usp=email )
Change subject: nft_kpi: add udp/2152 filtering rules separately ......................................................................
Patch Set 3:
(1 comment)
File src/osmo-hnbgw/nft_kpi.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/41752/comment/bfd7594e_7240d8b1?us... : PS3, Line 328: static int do_add_chain(bool uplink) While I agree with implementing a fix, I dislike the result as done in this patch because: * It mixes nftables rules for both directions into a function, which makes it more difficult to follow or grep in code for running ruleset. I'm totally fine with having a helper function (or 2, one per direction) as long as the nftables strings are kept as much clean as possible (eg. without "%srouting" uplink ? "ul" : "dl").
* It moves from 1 nft_run_now() calls to 3 of them. While peformance may not be that important here since this is called during startup, I think it's still nice to have all of it validated and applied atomically by running it with one nft_run_now().