Attention is currently required from: dexter, fixeria.
laforge has posted comments on this change by dexter. (
https://gerrit.osmocom.org/c/python/pyosmocom/+/38288?usp=email )
Change subject: tlv/cosmetic: improve import of osmocom functions
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/python/pyosmocom/+/38288/comment/cb33eb5d_9c0c…
:
PS1, Line 9: We can import osmocom and then reference
Of course we can do that, but what exactly does this
improve? […]
yes, there is such a conflict and I've asked @pmaier to mention
this already in my feedback
https://gerrit.osmocom.org/c/python/pyosmocom/+/38288/comments/744d81f2_da2…
AFAICT, pmaier split this out from a larger patch I originally created. I didn't have
an explanation as it was not a separate patch.
This must also be merged *before* tagging 0.0.5
--
To view, visit
https://gerrit.osmocom.org/c/python/pyosmocom/+/38288?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: I6ce3cffbce9b276de7b223d88268d35cf2706d6a
Gerrit-Change-Number: 38288
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 30 Sep 2024 17:16:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>