Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/27805 )
Change subject: osmo-bts-trx: fix scheduling of dummy FACCH/H and FACCH/F
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bts-trx/sched_tch.h:
https://gerrit.osmocom.org/c/osmo-bts/+/27805/comment/8eee5d15_10f64ae9
PS1, Line 26: static const uint8_t tch_dummy_facch[GSM_MACBLOCK_LEN] = {
I think it's usually not a good idea defining it
here without external. […]
Patchset was reworked, not relevant anymore.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/27805
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ief12eb67ad80de3b71f5226858dc2e0c8ae76948
Gerrit-Change-Number: 27805
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Apr 2022 11:22:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment