Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397?usp=email )
Change subject: Pass ownership of Rx xua_msg up the stack [2/2] ......................................................................
Patch Set 2:
(6 comments)
File src/ipa.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397/comment/29f5077a_e90f70... : PS2, Line 304: ownsership ```suggestion * xua ownership is passed here: */ ```
File src/m3ua.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397/comment/dffd42dd_90bd50... : PS2, Line 627: ownsership ```suggestion /* xua ownership is passed here: */ ```
https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397/comment/07ee013d_bb2134... : PS2, Line 784: goto out; missing `xua_msg_free(xua);` since it doesn't go through any `m3ua_rx_*`?
https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397/comment/8d4a16fc_3800a4... : PS2, Line 815: err = m3ua_gen_error_msg(M3UA_ERR_UNSUPP_MSG_CLASS, msg); missing `xua_msg_free(xua);` since it doesn't go through any `m3ua_rx_*`?
https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397/comment/281384d5_b21526... : PS2, Line 1015: return M3UA_ERR_UNSUPP_MSG_TYPE; ```suggestion rc = M3UA_ERR_UNSUPP_MSG_TYPE; ```
https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397/comment/ab8840ca_076b43... : PS2, Line 1019: return M3UA_ERR_UNSUPP_MSG_TYPE; ```suggestion rc = M3UA_ERR_UNSUPP_MSG_TYPE; ```