Change in osmo-uecups[master]: Fix use-after-free by tun thread after tun obj destroyed

Attention is currently required from: osmith, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/27739 ) Change subject: Fix use-after-free by tun thread after tun obj destroyed ...................................................................... Patch Set 3: (1 comment) File daemon/tun_device.c: https://gerrit.osmocom.org/c/osmo-uecups/+/27739/comment/cfa1f163_2d0db5d9 PS3, Line 200: pthread_cleanup_pop(1); Sorry we discussed this through jabber since it's a bit of a complex topic. In summary, check "man pthread_cleanup_push". push/pop can be implemented as a while loop, as specified by POSIX. And if you check /usr/include/pthread.h, it is actually implemented that way in linux. This adds further restrictions, like having to put both push/pop, and having to put them in the same function block. So in reality the function is not called, and we don't need it called, but it's needed to make the "do while" block. -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/27739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: Idf005359afb41d3413b09281a9ff937d5eafcc7c Gerrit-Change-Number: 27739 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 12 Apr 2022 09:18:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment