Attention is currently required from: lynxis lazus.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/30890 )
Change subject: gtp_{ggsn,mme}: Allocate contexts under struct sgsn_instance
......................................................................
Patch Set 1:
(2 comments)
File src/sgsn/gtp_ggsn.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/30890/comment/09fc0808_af46c083
PS1, Line 38: extern void *tall_sgsn_ctx;
this is unsused.
Ack
https://gerrit.osmocom.org/c/osmo-sgsn/+/30890/comment/b1ea3638_7b0e5580
PS1, Line 66: ggc = talloc_zero(sgsn, struct sgsn_ggsn_ctx);
I'm unsure if it wouldn't be much better to
add the sgsn parameter as it is used in sgsn_mme_ctx_all […]
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/30890
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ie65d59632a368c6957c33dca64e856ace792b2c6
Gerrit-Change-Number: 30890
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 11 Jan 2023 11:55:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: comment