Attention is currently required from: laforge, fixeria, daniel.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/32181 )
Change subject: tests: Add initial osmo_io tests
......................................................................
Patch Set 4:
(4 comments)
File tests/osmo_io/osmo_io_test.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6583):
https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/31da7f08_cea315e2
PS4, Line 54: printf("%s: Write returned rc=%d\n",osmo_iofd_get_name(iofd),
rc);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6583):
https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/05b4f770_08649d0f
PS4, Line 95: for (int i = 0; i < 128; i++) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6583):
https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/33b40a33_96e56b9c
PS4, Line 146: for (int i = 0; i < 128; i++) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6583):
https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/e5330bf9_1e1599ed
PS4, Line 174: }
adding a line without newline at end of file
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32181
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia67629e53f4d2e5784177250d58e268fdfcaa0c2
Gerrit-Change-Number: 32181
Gerrit-PatchSet: 4
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Apr 2023 13:14:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment