Attention is currently required from: laforge, neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email )
Change subject: per-HNB GTP-U traffic counters via nft ......................................................................
Patch Set 13:
(2 comments)
Patchset:
PS6:
regarding split files, i kind of like that everything is contained in a single .c file. […]
With thew new comments you added it's "good enough" because one can clearly see which thread executes that function, so we can merge it this way for now. My point is that, precisely, if you put all the nft thread in a seprate file, it suddenly becomes clear that all that code belongs to that thread, and you don't need to go marking each function specifying who runs it. Furthermore, it becomes easier to follow interaction of 2 threads by having one file open by the side of the other one.
File src/osmo-hnbgw/nft_kpi.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/3ecb5f62_9a8da3da PS12, Line 694: unsigned long period_us = osmo_tdef_get(hnbgw_T_defs, -34, OSMO_TDEF_US, 1000000);
ah yes this is exactly what i thought
yes, this is simple, usual in code, so I'm not asking something out of this world I think. Feel free to submit as a follow-up patch, but I definetly think this should be merged soon after this patch is merged.