Attention is currently required from: falconia, fixeria, jolly, laforge.
pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email )
Change subject: bring twjit into libosmo-netif
......................................................................
Patch Set 6:
(1 comment)
File include/osmocom/netif/twjit.h:
https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/bc99dac1_8bcd1e0e... :
PS6, Line 50: struct osmo_twjit_config {
@pespin@sysmocom. […]
Ok I see indeed. I am fine then with having a osmo_twjit_config_alloc() and osmo_twjit_config_free() API and keep the struct private (eg. src/twjit_private.h so it can be accessed by both twjit.c and twrtp.c if needed).
Then during osmo_twjit_config_init() copy/apply the config internally; caller is responsible for freeing it when needed.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658
Gerrit-Change-Number: 39280
Gerrit-PatchSet: 6
Gerrit-Owner: falconia
falcon@freecalypso.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: jolly
andreas@eversberg.eu
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Attention: falconia
falcon@freecalypso.org
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Wed, 27 Aug 2025 11:23:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia
falcon@freecalypso.org
Comment-In-Reply-To: pespin
pespin@sysmocom.de
