Attention is currently required from: Hoernchen, pespin.
laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email )
Change subject: core: fix config.h
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS4:
This approach does not guard us against new files being added without including `config.h` in them. […]
I think you have a point here. I think if we rely on #including a file from every source but it doesn't break during compile, then we will see this bug re-appearing all over again as somebody won't remember having to include config.h unconditionally everywhere...
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic2cf52a3b60f43a2f5d3fe01c41a41f6fd9a8000
Gerrit-Change-Number: 42205
Gerrit-PatchSet: 4
Gerrit-Owner: Hoernchen
ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: Hoernchen
ewild@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 25 Feb 2026 17:47:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de