26 Jul
2023
26 Jul
'23
1:21 p.m.
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33933 )
Change subject: csd_bs_list_to_bearer_cap(): add default branch for safety ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I don't see how adding the default branch there adds safety...
Well, if `bs_map[bs].rate` is not handled in switch, then `cap->data.{user,interm}_rate` fields are not properly initialized (i.e. set to 0, which is a reserved values for both).
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33933
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ibfb71d1ece502585b55db0f28069a6aa0666b9df
Gerrit-Change-Number: 33933
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 26 Jul 2023 11:21:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment