wbokslag has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-tetra/+/28596 )
Change subject: fixed out of bounds write to pdu_sync buffer
......................................................................
Patch Set 2:
(1 comment)
File src/conv_enc_test.c:
https://gerrit.osmocom.org/c/osmo-tetra/+/28596/comment/629541fa_5b932491
PS1, Line 338: *((uint32_t *)pdu_sync) = r;
are we sure pdu_sync is always aligned and the
type-cast is safe even on architectures that don't do […]
Although the pdu_sync
buffer will almost certainly be at least dword-aligned, I took your recommendation and the
code now uses osmo_store32le.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-tetra/+/28596
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: I414bf2d61dc1cb37d30dc84b401a75b918116bbb
Gerrit-Change-Number: 28596
Gerrit-PatchSet: 2
Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 02 Aug 2022 11:26:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment