Attention is currently required from: kirr.
fixeria has posted comments on this change by kirr. (
https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email )
Change subject: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency
killer
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Unfortunately os.timerfd_create() & friends
are only available starting […]
Looks good to me, thank you!
Just one moment: can we somehow do this earlier in the patchset? Otherwise one would have
to bypass the build verification for most of the patches in this set. Not only this is
annoying (it needs to be done manually for each patch), but also imposes a risk of not
noticing a regression somewhere in the middle.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Iaa675c95059ec8ccfad667f69984d5a7f608c249
Gerrit-Change-Number: 40047
Gerrit-PatchSet: 1
Gerrit-Owner: kirr <kirr(a)nexedi.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: kirr <kirr(a)nexedi.com>
Gerrit-Comment-Date: Fri, 18 Apr 2025 07:24:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: kirr <kirr(a)nexedi.com>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>