16 Jun
2023
16 Jun
'23
2:50 p.m.
Attention is currently required from: daniel.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33336 )
Change subject: stream: Allow setting name printed during logging ......................................................................
Patch Set 2:
(1 comment)
File src/stream.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33336/comment/8d51a067_8c85cd2b PS1, Line 1228: struct osmo_stream_srv_link *osmo_stream_srv_link_create(void *ctx)
Yesterday we were debating about keeping the API consistent. […]
Did we add all the *2 APIs since around last week? Can we maybe remove the "name" param from all those *2 APIs then? And leave them aside to be set through _set_name() API. What do you think?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33336
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I539a0d29d11348efe702f971965a55cf56db5c59
Gerrit-Change-Number: 33336
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Fri, 16 Jun 2023 12:50:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: daniel dwillmann@sysmocom.de
Gerrit-MessageType: comment