Attention is currently required from: pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-upf/+/27222
)
Change subject: libosmo-pfcp: implement/generate TLV and IE value coding
......................................................................
Patch Set 2:
(1 comment)
File src/libosmo-pfcp/gen__pfcp_ies_auto.c:
https://gerrit.osmocom.org/c/osmo-upf/+/27222/comment/17e11ce3_c2ecf049
PS1, Line 42: .dec_enc = "32be",
we should have enums for this imho.
gen works
such that this "32be" string genereates function calls to
"myproto_dec_32be()" and "myproto_enc_32be()". It is up to the
individual protocol to implement these in a myproto_ies_custom.c, an enum is not
applicable here.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-upf/+/27222
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I3069045b2d42dac88d955c636230adc64a7a4aa7
Gerrit-Change-Number: 27222
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Mar 2022 14:39:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment