Attention is currently required from: neels, pespin, fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30963 )
Change subject: mobile: fix -Wlogical-not-parentheses in gsm48_cc_init()
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/host/layer23/src/mobile/gsm48_cc.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30963/comment/07a7a93f_6b41cb53
PS1, Line 54: if (cc->mncc_upqueue.next != NULL)
Feel free to merge this patch if you want, but I think
we really fix the code to properly initialize […]
agreeing with pespin here. we can
merged this first and then clean it up properly later.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30963
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ic7ffd3aa25339e24a31bae1b7428f1f93e261858
Gerrit-Change-Number: 30963
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 06 Feb 2023 16:08:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment