pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853 )
Change subject: pgw: Initial Gy support ......................................................................
Patch Set 3:
(1 comment)
File pgw/PGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853/comment/0ca3fb66_a77d0... PS2, Line 320: Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
Well, I generally don't like that f_shutdown() is overloaded with setting a verdict. […]
You may have the opinion that f_shutdown() is overloaded by setting the veredict (and I disagree), but that's totally unrelated to what the patch is doing: just using an available function with its available parameters. This patch is not adding or touching that function. Feel free to send a patch dropping the verdict stuff from Misc_Helpers.f_shutdown() and everywhere using it if you want, and let others give their opinion.