Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email )
Change subject: tests/testsuite.at: fix invalid if-endif syntax
......................................................................
Patch Set 1:
(1 comment)
File tests/testsuite.at:
https://gerrit.osmocom.org/c/libosmocore/+/41362/comment/28b2f425_f1cd1a79?u... :
PS1, Line 86: AT_SKIP_IF([test ! -e $abs_top_builddir/tests/msgfile/msgfile_test])
Well, we already do this kind of checking in several projects. […]
We seem to be already supporting this with a variable, see libosmocore/tests/testsuite.at:
551:AT_SKIP_IF([ test "$ENABLE_URING" != "yes" || test "$ENABLE_URING_TESTS" != "yes" ])
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I81e044dc0bda4674c0d0dc46118d46816712a76c
Gerrit-Change-Number: 41362
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Thu, 06 Nov 2025 15:16:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: lynxis lazus
lynxis@fe80.eu