20 Apr
2022
20 Apr
'22
2:58 p.m.
Attention is currently required from: manawyrm, roox, tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27841 )
Change subject: e1oip: Add rate_ctr for IP->E1 RIFO overflows ......................................................................
Patch Set 4:
(1 comment)
File src/octoi/e1oip.c:
https://gerrit.osmocom.org/c/osmo-e1d/+/27841/comment/496a4884_0cea5320 PS2, Line 255: rc = frame_rifo_in(&iline->e1t.rifo, frame_buf, fn32+i);
That's not really correct. […]
so what kind of naming would you prefer? e1oip:e1t_out_of_ragge? out_of_window? I somehow like the orthogonality of e1t_overflow with e1o_overflow that we already have. But not sure if that is worth introducing misnamed counters?
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27841
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ie0e8bb2f5d2ae4256952f6bf69e514d5c2627a76
Gerrit-Change-Number: 27841
Gerrit-PatchSet: 4
Gerrit-Owner: laforge laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: manawyrm osmocom.account@tbspace.de
Gerrit-Reviewer: roox mardnh@gmx.de
Gerrit-Reviewer: tnt tnt@246tNt.com
Gerrit-Attention: manawyrm osmocom.account@tbspace.de
Gerrit-Attention: roox mardnh@gmx.de
Gerrit-Attention: tnt tnt@246tNt.com
Gerrit-Comment-Date: Wed, 20 Apr 2022 12:58:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: tnt tnt@246tNt.com
Gerrit-MessageType: comment