Change in osmo-ttcn3-hacks[master]: BSC: extend TC_ho_meas_rep_multi_band for ARFCN=0

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29858 ) Change subject: BSC: extend TC_ho_meas_rep_multi_band for ARFCN=0 ...................................................................... Patch Set 2: (1 comment) This change is ready for review. File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29858/comment/3d7c164b_7b89… PS1, Line 11979: 40 Thanks for taking a look! You are right, it is getting encoded properly. I was confused by: * the indentation in wireshark, I thought the neighbor is encoded as BCCH-FREQ-NCELL, BSIC-NCELL, RXLEV-NCELL. But in the spec it's actually RXLV-NCELL, BCCH-FREQ-NCELL, BSIC-NCELL. Also as you showed with the comments above in the tshark output. * by bcch_freq of each entry. I did not set it to 1, 2, 3, 0 on purpose, but this of course caused the shift between the index I thought of (as indicated by the ARFCN ... comments here) and the index that was sent. I've changed it to 0, 1, 2, 3 now and now the test works as it should, and passes with the patches applied. I guess you tested against osmo-bsc master, before https://gerrit.osmocom.org/c/osmo-bsc/+/29836 was merged. Without fixing bcch_freq, it also passes for me there. But this is by chance. After fixing bcch_freq, the test fails without the osmo-bsc patch applied, and passes with it applied. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29858 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia8f94d72651061427afc9e34f678544f89d0149b Gerrit-Change-Number: 29858 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Oct 2022 11:11:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment