Attention is currently required from: wbokslag. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29387 )
Change subject: added support for fill bits and basic link defragmentation (also thanks to SQ5BPF) ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Patchset:
PS2: Not really critical, looks good in general.
File src/tetra_llc_pdu.h:
https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/a75dc52c_27c6ef83 PS1, Line 80:
tl_sdu_len needs to be changed from a uint8_t to uint32_t because, due to defragmentation, pdus may […]
I meant to say "unrelated WhiteSpace change", sorry for not being clear. What I wanted to point out is that you're adding two tabs here for no reason. You're changing the line below, this one should remain unchanged.