Attention is currently required from: jolly, pespin, dexter.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/33448 )
Change subject: ASCI: Add Notification/FACCH support
......................................................................
Patch Set 5:
(1 comment)
File src/common/rsl.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33448/comment/65995f4c_ab1d1e92
PS5, Line 814: broadcast_facch
AFAIU, this function is broadcasting FACCH on all channels, even if they're not
related to VGCS/VBS. Am I missing something? I am guessing it's expected that all
lchans on a VGCS/VBS capable BTS are treated as VGCS/VBS?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/33448
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3ed14fa54a907891e492a7ada8e745a2c56cd46d
Gerrit-Change-Number: 33448
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Jul 2023 14:35:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment