Attention is currently required from: Hoernchen, laforge, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/35854?usp=email )
Change subject: tests: rlcmac: Reproduce bug encoding 2 llc frames in 1 rlc block
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
File tests/rlcmac/rlcmac_prim_test.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/35854/comment/2c828cb4_a900c60f
PS1, Line 1327: rc = osmo_gprs_rlcmac_prim_upper_down
(not critical) `rc` set, but not checked/asserted
https://gerrit.osmocom.org/c/libosmo-gprs/+/35854/comment/edfb74e8_7936287a
PS1, Line 1336: PAACH
PACCH?
https://gerrit.osmocom.org/c/libosmo-gprs/+/35854/comment/143bc4d3_dcecc8a6
PS1, Line 1346: rc = osmo_gprs_rlcmac_prim_upper_down
(not critical) `rc` set, but not checked/asserted
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/35854?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I2f654bcefd6a2f192b9742873b8cb70a63bbfbd1
Gerrit-Change-Number: 35854
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Feb 2024 12:36:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment