Attention is currently required from: falconia, pespin.
fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/38555?usp=email )
Change subject: CSD RTP: verify alignment of V.110 frames ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File src/common/csd_v110.c:
https://gerrit.osmocom.org/c/osmo-bts/+/38555/comment/7be057c4_ad8d113b?usp=... : PS2, Line 158: for (i = 0; i < 8; i++) { We can avoid if-statement in loops to improve performance (in theory):
``` ubit_t bit0 = 0; ubit_t bit1 = 1;
for (i = 0; i < 8; i++) bit0 |= ra_bits[i]; for (i = 1; i < 10; i++) bit1 &= ra_bits[i * 8];
return (bit0 == 0) && (bit1 == 1); ```
https://gerrit.osmocom.org/c/osmo-bts/+/38555/comment/3e949862_619f828a?usp=... : PS2, Line 204: return -EINVAL;
We do have a rate_ctr: when `csd_v110_rtp_decode()` returns negative, the code in `l1sap_rtp_rx_cb() […]
Acknowledged