26 May
2024
26 May
'24
5:06 a.m.
Attention is currently required from: neels, nt2mku.
falconia has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email )
Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is
supported
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
In my opinion, this patch is trying to solve the wrong problem, or trying to solve the
problem in the wrong place. Table 10.5.102/3GPP TS 24.008 says quite clearly that the
radio channel requirement bits of octet 3 and all of octet 3a etc are meaningful only in
the MS to network direction. In the network to MS direction, the spec calls for a fixed
dummy value in the radio channel requirement bits, and although it does not directly spell
out that octet 3a etc shall be omitted, it does say "Octets 3a etc. shall be ignored
by the MS."
IMO, the course course of action for the MSC (where the author of this patch is
experiencing the actual problem) is to never include octets 3a etc on MT calls; I would go
even further and say that the entire bearer cap IE should be included in the MT SETUP
message only for data calls, and omitted altogether for speech calls. The spec makes this
IE optional in the MT direction specifically for this reason.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b
Gerrit-Change-Number: 36784
Gerrit-PatchSet: 7
Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: falconia <falcon(a)freecalypso.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com>
Gerrit-Comment-Date: Sun, 26 May 2024 05:06:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment