Attention is currently required from: daniel, fixeria, laforge, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email )
Change subject: stp: Introduce tests to validate inaccessible SP scenario ......................................................................
Patch Set 2:
(1 comment)
File stp/STP_Tests_M3UA.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525/comment/aad23743_c3224... : PS2, Line 207: "while waiting for ", msg)); IMHO the error messages are hard to understand. - the first message could mention that the message is unexpected within the timer - the second message has "while waiting for", but this function does the opposite, it waits for the timer to pass and checks that the message does *not* arrive
I wonder if the msg parameter is even useful, couldn't it just ensure that no message arrives (except for the beat if answer_beat is true) until the timeout is done, and have one obvious error message saying that an unexpected message arrived before the timeout?